netdev - Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210723060631.GA32369@lst.de>
Date:   Fri, 23 Jul 2021 08:06:31 +0200
From:   Christoph Hellwig <hch@....de>
To:     Boris Pismenny <borisp@...dia.com>
Cc:     dsahern@...il.com, kuba@...nel.org, davem@...emloft.net,
        saeedm@...dia.com, hch@....de, sagi@...mberg.me, axboe@...com,
        kbusch@...nel.org, viro@...iv.linux.org.uk, edumazet@...gle.com,
        smalin@...vell.com, boris.pismenny@...il.com,
        linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
        benishay@...dia.com, ogerlitz@...dia.com, yorayz@...dia.com,
        Boris Pismenny <borisp@...lanox.com>
Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock

On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote:
> From: Boris Pismenny <borisp@...lanox.com>
> 
> get_netdev_for_sock is a utility that is used to obtain
> the net_device structure from a connected socket.
> 
> Later patches will use this for nvme-tcp DDP and DDP DDGST offloads.
> 
> Signed-off-by: Boris Pismenny <borisp@...lanox.com>
> Reviewed-by: Sagi Grimberg <sagi@...mberg.me>

I don't think this should be an inline.  Please move it to net/core/dev.c,
andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment.