netdev - Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d152389f-815b-34f9-b6f4-a4cb6377ab4f@fb.com>
Date:   Tue, 27 Jul 2021 09:43:22 -0700
From:   Yonghong Song <yhs@...com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>,
        <magnus.karlsson@...el.com>, <bjorn@...nel.org>, <ast@...nel.org>,
        <daniel@...earbox.net>, <netdev@...r.kernel.org>,
        <maciej.fijalkowski@...el.com>
CC:     <jonathan.lemon@...il.com>, <ciara.loftus@...el.com>,
        <joamaki@...il.com>, <bpf@...r.kernel.org>, <andrii@...nel.org>
Subject: Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode



On 7/27/21 6:17 AM, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@...el.com>
> 
> Remove color mode.

Could you add some reasoning in the commit message why
removing color mode is a good idea?

> 
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> ---
>   tools/testing/selftests/bpf/test_xsk.sh    | 10 +++-----
>   tools/testing/selftests/bpf/xsk_prereqs.sh | 27 +++++-----------------
>   2 files changed, 9 insertions(+), 28 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> index 46633a3bfb0b..cd7bf32e6a17 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -63,14 +63,11 @@
>   # ----------------
>   # Must run with CAP_NET_ADMIN capability.
>   #
> -# Run (full color-coded output):
> -#   sudo ./test_xsk.sh -c
> +# Run:
> +#   sudo ./test_xsk.sh
>   #
>   # If running from kselftests:
> -#   sudo make colorconsole=1 run_tests
> -#
> -# Run (full output without color-coding):
> -#   sudo ./test_xsk.sh
> +#   sudo make run_tests
[...]