netdev - Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz0CrDab86Ajdx+1Gkt8-7Lh-SEKg0iKgEeiYF0Na5+VFA@mail.gmail.com>
Date:   Wed, 28 Jul 2021 08:12:54 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Ciara Loftus <ciara.loftus@...el.com>,
        Jussi Maki <joamaki@...il.com>, bpf <bpf@...r.kernel.org>,
        Andrii Nakryiko <andrii@...nel.org>
Subject: Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode

On Tue, Jul 27, 2021 at 6:43 PM Yonghong Song <yhs@...com> wrote:
>
>
>
> On 7/27/21 6:17 AM, Magnus Karlsson wrote:
> > From: Magnus Karlsson <magnus.karlsson@...el.com>
> >
> > Remove color mode.
>
> Could you add some reasoning in the commit message why
> removing color mode is a good idea?

Will do. The reason is that I do not see color text output adding any
value and less code means less of a maintenance burden which is a good
thing. But if someone feels that color output is adding value and is
using it, I can likely be convinced to keep it.

> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> > ---
> >   tools/testing/selftests/bpf/test_xsk.sh    | 10 +++-----
> >   tools/testing/selftests/bpf/xsk_prereqs.sh | 27 +++++-----------------
> >   2 files changed, 9 insertions(+), 28 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> > index 46633a3bfb0b..cd7bf32e6a17 100755
> > --- a/tools/testing/selftests/bpf/test_xsk.sh
> > +++ b/tools/testing/selftests/bpf/test_xsk.sh
> > @@ -63,14 +63,11 @@
> >   # ----------------
> >   # Must run with CAP_NET_ADMIN capability.
> >   #
> > -# Run (full color-coded output):
> > -#   sudo ./test_xsk.sh -c
> > +# Run:
> > +#   sudo ./test_xsk.sh
> >   #
> >   # If running from kselftests:
> > -#   sudo make colorconsole=1 run_tests
> > -#
> > -# Run (full output without color-coding):
> > -#   sudo ./test_xsk.sh
> > +#   sudo make run_tests
> [...]