netdev - Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bcca610-601d-86d0-4d74-0e5055431738@gmail.com>
Date:   Sun, 1 Aug 2021 18:25:52 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before
 ethtool ops

On 01.08.2021 12:35, Heiner Kallweit wrote:
> If a network device is runtime-suspended then:
> - network device may be flagged as detached and all ethtool ops (even if
>   not accessing the device) will fail because netif_device_present()
>   returns false
> - ethtool ops may fail because device is not accessible (e.g. because being
>   in D3 in case of a PCI device)
> 
> It may not be desirable that userspace can't use even simple ethtool ops
> that not access the device if interface or link is down. To be more friendly
> to userspace let's ensure that device is runtime-resumed when executing
> ethtool ops in kernel.
> 
> This patch series covers the typical case that the netdev parent is power-
> managed, e.g. a PCI device. Not sure whether cases exist where the netdev
> itself is power-managed. If yes then we may need an extension for this.
> But the series as-is at least shouldn't cause problems in that case.
> 
> Heiner Kallweit (4):
>   ethtool: runtime-resume netdev parent before ethtool ioctl ops
>   ethtool: move implementation of ethnl_ops_begin/complete to netlink.c
>   ethtool: move netif_device_present check from
>     ethnl_parse_header_dev_get to ethnl_ops_begin
>   ethtool: runtime-resume netdev parent in ethnl_ops_begin
> 
>  net/ethtool/ioctl.c   | 18 ++++++++++++++---
>  net/ethtool/netlink.c | 45 +++++++++++++++++++++++++++++++++++++------
>  net/ethtool/netlink.h | 15 ++-------------
>  3 files changed, 56 insertions(+), 22 deletions(-)
> 

Patchwork is showing the following warning for all patches in the series.

netdev/cc_maintainers	warning	7 maintainers not CCed: ecree@...arflare.com andrew@...n.ch magnus.karlsson@...el.com danieller@...dia.com arnd@...db.de irusskikh@...vell.com alexanderduyck@...com

This seems to be a false positive, e.g. address ecree@...arflare.com
doesn't exist at all in MAINTAINERS file.