netdev - Re: [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFki+LkNzk0ajUeuBnJZ6mp1kxB0+zZf60tw1Vfq+nPy-bvftQ@mail.gmail.com>
Date:   Mon, 2 Aug 2021 11:26:39 -0400
From:   Nitesh Lal <nilal@...hat.com>
To:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, jassisinghbrar@...il.com,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Tushar.Khandelwal@....com, manivannan.sadhasivam@...aro.org,
        lewis.hanly@...rochip.com, ley.foon.tan@...el.com,
        kabel@...nel.org, huangguangbin2@...wei.com, davem@...emloft.net,
        benve@...co.com, govind@....com, kashyap.desai@...adcom.com,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        shivasharan.srikanteshwara@...adcom.com,
        sathya.prakash@...adcom.com,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        suganath-prabu.subramani@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        linux-pci@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        rostedt@...dmis.org, Marc Zyngier <maz@...nel.org>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Robin Murphy <robin.murphy@....com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Ingo Molnar <mingo@...nel.org>, jbrandeb@...nel.org,
        Frederic Weisbecker <frederic@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Alex Belits <abelits@...vell.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        akpm@...uxfoundation.org, sfr@...b.auug.org.au,
        stephen@...workplumber.org, rppt@...ux.vnet.ibm.com,
        chris.friesen@...driver.com, Neil Horman <nhorman@...driver.com>,
        pjwaskiewicz@...il.com, Stefan Assmann <sassmann@...hat.com>,
        Tomas Henzl <thenzl@...hat.com>, james.smart@...adcom.com,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        Ken Cox <jkc@...hat.com>, faisal.latif@...el.com,
        shiraz.saleem@...el.com, tariqt@...dia.com,
        Alaa Hleihel <ahleihel@...hat.com>,
        Kamal Heib <kheib@...hat.com>, borisp@...dia.com,
        saeedm@...dia.com, Nitesh Lal <nilal@...hat.com>,
        "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        Al Stone <ahs3@...hat.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Chandrakanth Patil <chandrakanth.patil@...adcom.com>,
        bjorn.andersson@...aro.org, chunkuang.hu@...nel.org,
        yongqiang.niu@...iatek.com, baolin.wang7@...il.com,
        Petr Oros <poros@...hat.com>, Ming Lei <minlei@...hat.com>,
        Ewan Milne <emilne@...hat.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()

On Tue, Jul 20, 2021 at 7:26 PM Nitesh Narayan Lal <nitesh@...hat.com> wrote:
>
> The drivers currently rely on irq_set_affinity_hint() to either set the
> affinity_hint that is consumed by the userspace and/or to enforce a custom
> affinity.
>
> irq_set_affinity_hint() as the name suggests is originally introduced to
> only set the affinity_hint to help the userspace in guiding the interrupts
> and not the affinity itself. However, since the commit
>
>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
>

[...]

>  drivers/infiniband/hw/irdma/hw.c              |  4 +-
>  drivers/mailbox/bcm-flexrm-mailbox.c          |  4 +-
>  drivers/net/ethernet/cisco/enic/enic_main.c   |  8 +--
>  drivers/net/ethernet/emulex/benet/be_main.c   |  4 +-
>  drivers/net/ethernet/huawei/hinic/hinic_rx.c  |  4 +-
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  8 +--
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 +--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++--
>  drivers/net/ethernet/mellanox/mlx4/eq.c       |  8 ++-
>  .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  8 +--
>  drivers/scsi/lpfc/lpfc_init.c                 |  4 +-
>  drivers/scsi/megaraid/megaraid_sas_base.c     | 27 +++++-----
>  drivers/scsi/mpt3sas/mpt3sas_base.c           | 21 ++++----
>  include/linux/interrupt.h                     | 53 ++++++++++++++++++-
>  kernel/irq/manage.c                           |  8 +--
>  15 files changed, 114 insertions(+), 65 deletions(-)
>
> --
>
>

Gentle ping.
Any comments on the following patches:

  genirq: Provide new interfaces for affinity hints
  scsi: megaraid_sas: Use irq_set_affinity_and_hint
  scsi: mpt3sas: Use irq_set_affinity_and_hint
  enic: Use irq_update_affinity_hint
  be2net: Use irq_update_affinity_hint
  mailbox: Use irq_update_affinity_hint
  hinic: Use irq_set_affinity_and_hint

or any other patches?

-- 
Thanks
Nitesh