netdev - Re: leds: netdev trigger - misleading link state indication at boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Aug 2021 18:01:54 +0200
From:   Pavel Machek <pavel@....cz>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Ben Whitten <ben.whitten@...il.com>, Dan Murphy <dmurphy@...com>,
        linux-leds@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: leds: netdev trigger - misleading link state indication at boot

Hi!

> I'm seeing some odd behaviour with the netdev trigger and some WiFi
> interfaces.
> 
> When the WiFi interface has never been brought up (so is in an
> operationally disabled state), if I bind a LED to the netdev
> trigger, setting the device_name to the WiFi interface name and
> enable the "link" property, the LED illuminates, indicating that
> the WiFi device has link - but it's disabled.
> 
> If I up/down the WiFi interface, thereby returning it to the
> original state, the link LED goes out.
> 
> I suspect ledtrig-netdev.c needs to check that the device is both
> up (dev->flags & IFF_UP) and netif_carrier_ok(dev) both return true,
> rather than just relying on netif_carrier_ok(). I don't think using
> netif_running() is appropriate, as that will return true before
> ndo_open() has been called to initialise the carrier state.
> 
> Agreed?

Seems reasonable to me. Will you do the patch?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)