netdev - Re: [PATCH net-next] net: wwan: mhi_wwan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsQCNfLhxm8FxAb8EPKuK+6YFPVx55_SvJMTcg12MjUnJw@mail.gmail.com>
Date:   Fri, 6 Aug 2021 13:38:49 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH net-next] net: wwan: mhi_wwan_ctrl: Fix possible deadlock

On Fri, Aug 6, 2021 at 1:24 PM Loic Poulain <loic.poulain@...aro.org> wrote:
> Lockdep detected possible interrupt unsafe locking scenario:
>
>         CPU0                    CPU1
>         ----                    ----
>    lock(&mhiwwan->rx_lock);
>                                local_irq_disable();
>                                lock(&mhi_cntrl->pm_lock);
>                                lock(&mhiwwan->rx_lock);
>    <Interrupt>
>      lock(&mhi_cntrl->pm_lock);
>
>   *** DEADLOCK ***
>
> To prevent this we need to disable the soft-interrupts when taking
> the rx_lock.
>
> Cc: stable@...r.kernel.org
> Fixes: fa588eba632d ("net: Add Qcom WWAN control driver")
> Reported-by: Thomas Perrot <thomas.perrot@...tlin.com>
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>