netdev - Re: [PATCH net-next] net: wwan: mhi_wwan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210806154721.0333f733@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 6 Aug 2021 15:47:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        ryazanov.s.a@...il.com, stable@...r.kernel.org
Subject: Re: [PATCH net-next] net: wwan: mhi_wwan_ctrl: Fix possible
 deadlock

On Fri,  6 Aug 2021 12:35:09 +0200 Loic Poulain wrote:
> Lockdep detected possible interrupt unsafe locking scenario:
> 
>         CPU0                    CPU1
>         ----                    ----
>    lock(&mhiwwan->rx_lock);
>                                local_irq_disable();
>                                lock(&mhi_cntrl->pm_lock);
>                                lock(&mhiwwan->rx_lock);
>    <Interrupt>
>      lock(&mhi_cntrl->pm_lock);
> 
>   *** DEADLOCK ***
> 
> To prevent this we need to disable the soft-interrupts when taking
> the rx_lock.
> 
> Cc: stable@...r.kernel.org
> Fixes: fa588eba632d ("net: Add Qcom WWAN control driver")
> Reported-by: Thomas Perrot <thomas.perrot@...tlin.com>
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>

This is for net, right? Despite it's subject annotation?