netdev - Re: [PATCH] net/mlx5e: Make use of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Aug 2021 13:24:38 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     saeedm@...dia.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Make use of pr_warn()

On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
> to replace printk(KERN_WARNING ...) with pr_warn() kindly
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index e5c4344a114e..ab7c059e630f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2702,7 +2702,7 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
>  		if (s_mask && a_mask) {
>  			NL_SET_ERR_MSG_MOD(extack,
>  					   "can't set and add to the same HW field");
> -			printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field);
> +			pr_warn("mlx5: can't set and add to the same HW field (%x)\n", f->field);

It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.

>  			return -EOPNOTSUPP;
>  		}
>  
> @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
>  		if (first < next_z && next_z < last) {
>  			NL_SET_ERR_MSG_MOD(extack,
>  					   "rewrite of few sub-fields isn't supported");
> -			printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> -			       mask);
> +			pr_warn("mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> +				mask);

ditto

Thanks

>  			return -EOPNOTSUPP;
>  		}
>  
> -- 
> 2.25.1
>