netdev - Re: [PATCH] net/mlx5e: Make use of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <744a99a3de26300fc244d5b7702c87a9dd926e6e.camel@nvidia.com>
Date:   Mon, 9 Aug 2021 20:37:07 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "caihuoqing@...du.com" <caihuoqing@...du.com>,
        "leon@...nel.org" <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Make use of pr_warn()

On Mon, 2021-08-09 at 13:24 +0300, Leon Romanovsky wrote:
> On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
> 

[...]

> > -                       printk(KERN_WARNING "mlx5: can't set and
> > add to the same HW field (%x)\n", f->field);
> > +                       pr_warn("mlx5: can't set and add to the
> > same HW field (%x)\n", f->field);
> 
> It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
> 

please use: netdev_warn(priv->netdev,

> >                         return -EOPNOTSUPP;
> >                 }
> >  
> > @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct
> > mlx5e_priv *priv,
> >                 if (first < next_z && next_z < last) {
> >                         NL_SET_ERR_MSG_MOD(extack,
> >                                            "rewrite of few sub-
> > fields isn't supported");
> > -                       printk(KERN_WARNING "mlx5: rewrite of few
> > sub-fields (mask %lx) isn't offloaded\n",
> > -                              mask);
> > +                       pr_warn("mlx5: rewrite of few sub-fields
> > (mask %lx) isn't offloaded\n",
> > +                               mask);
> 
> ditto
> 

same