netdev - Re: [PATCH net-next 5/5] igc: Export LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 21:53:35 +0200
From:   Pavel Machek <pavel@....cz>
To:     Marek Behún <kabel@...nel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Michael Walle <michael@...le.cc>, andrew@...n.ch,
        anthony.l.nguyen@...el.com, bigeasy@...utronix.de,
        davem@...emloft.net, dvorax.fuxbrumer@...ux.intel.com,
        f.fainelli@...il.com, jacek.anaszewski@...il.com, kuba@...nel.org,
        kurt@...utronix.de, linux-leds@...r.kernel.org,
        netdev@...r.kernel.org, sasha.neftin@...el.com,
        vinicius.gomes@...el.com, vitaly.lifshits@...el.com
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs

Hi!

> > So "r8159-0300:green:activity" would be closer to the naming we want,
> > but lets not do that, we really want this to be similar to what others
> > are doing, and that probably means "ethphy3:green:activity" AFAICT.
> 
> Pavel, one point of the discussion is that in this case the LED is
> controlled by MAC, not PHY. So the question is whether we want to do
> "ethmacN" (in addition to "ethphyN").

Sorry, I missed that. I guess that yes, ethmacX is okay, too.

Even better would be to find common term that could be used for both
ethmacN and ethphyN and just use that. (Except that we want to avoid
ethX). Maybe "ethportX" would be suitable?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)