netdev - Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ef818ee-ee75-b2f0-5532-7cc3fa4eb68e@fb.com>
Date:   Tue, 10 Aug 2021 16:46:49 -0700
From:   Yonghong Song <yhs@...com>
To:     Kuniyuki Iwashima <kuniyu@...zon.co.jp>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>
CC:     Benjamin Herrenschmidt <benh@...zon.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX
 domain socket iterator program.



On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
> The iterator can output the same result compared to /proc/net/unix.
> 
>    # cat /sys/fs/bpf/unix
>    Num       RefCount Protocol Flags    Type St Inode Path
>    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer

There seems a misalignment between header line and data line.
I know /proc/net/unix having this issue as well. But can we adjust 
spacing in bpf program to make header/data properly aligned?

>    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@...ld@
> 
>    # cat /proc/net/unix
>    Num       RefCount Protocol Flags    Type St Inode Path
>    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
>    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@...ld@
> 
> Note that this prog requires the patch ([0]) for LLVM code gen.  Thanks to
> Yonghong Song for analysing and fixing.
> 
> [0] https://reviews.llvm.org/D107483
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>

LGTM. Thanks!

Acked-by: Yonghong Song <yhs@...com>