netdev - Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Aug 2021 10:35:57 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <yhs@...com>
CC:     <andrii@...nel.org>, <ast@...nel.org>, <benh@...zon.com>,
        <bpf@...r.kernel.org>, <daniel@...earbox.net>,
        <davem@...emloft.net>, <john.fastabend@...il.com>, <kafai@...com>,
        <kpsingh@...nel.org>, <kuba@...nel.org>, <kuni1840@...il.com>,
        <kuniyu@...zon.co.jp>, <netdev@...r.kernel.org>,
        <songliubraving@...com>
Subject: Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.

From:   Yonghong Song <yhs@...com>
Date:   Tue, 10 Aug 2021 16:46:49 -0700
> On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
> > The iterator can output the same result compared to /proc/net/unix.
> > 
> >    # cat /sys/fs/bpf/unix
> >    Num       RefCount Protocol Flags    Type St Inode Path
> >    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
> 
> There seems a misalignment between header line and data line.
> I know /proc/net/unix having this issue as well. But can we adjust 
> spacing in bpf program to make header/data properly aligned?

I just followed /proc/net/unix not to break old parsers :)
I'll align it cleanly in the next spin.


> 
> >    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@...ld@
> > 
> >    # cat /proc/net/unix
> >    Num       RefCount Protocol Flags    Type St Inode Path
> >    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
> >    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@...ld@
> > 
> > Note that this prog requires the patch ([0]) for LLVM code gen.  Thanks to
> > Yonghong Song for analysing and fixing.
> > 
> > [0] https://reviews.llvm.org/D107483
> > 
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> 
> LGTM. Thanks!
> 
> Acked-by: Yonghong Song <yhs@...com>

Thank you, too!!