netdev - Re: [PATCH] qed: qed ll2 race condition fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210811155137.5ec90835@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 11 Aug 2021 15:51:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shai Malin <smalin@...vell.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <aelior@...vell.com>, <malin1024@...il.com>
Subject: Re: [PATCH] qed: qed ll2 race condition fixes

On Wed, 11 Aug 2021 19:28:55 +0300 Shai Malin wrote:
> @@ -1728,6 +1746,8 @@ int qed_ll2_post_rx_buffer(void *cxt,
>  	if (!p_ll2_conn)
>  		return -EINVAL;
>  	p_rx = &p_ll2_conn->rx_queue;
> +	if (p_rx->set_prod_addr == NULL)
> +		return -EIO;

Please use !p_rx->set_prod_addr as suggested by checkpatch