netdev - RE: [EXT] Re: [PATCH] qed: qed ll2 race condition fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB388284DF80D4609FC8DD9ADDCCF99@SJ0PR18MB3882.namprd18.prod.outlook.com>
Date:   Thu, 12 Aug 2021 03:38:02 +0000
From:   Shai Malin <smalin@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Ariel Elior <aelior@...vell.com>,
        "malin1024@...il.com" <malin1024@...il.com>
Subject: RE: [EXT] Re: [PATCH] qed: qed ll2 race condition fixes

On Thu, 12 Aug 2021 at 01:51, Jakub Kicinski wrote: 
> On Wed, 11 Aug 2021 19:28:55 +0300 Shai Malin wrote:
> > @@ -1728,6 +1746,8 @@ int qed_ll2_post_rx_buffer(void *cxt,
> >  	if (!p_ll2_conn)
> >  		return -EINVAL;
> >  	p_rx = &p_ll2_conn->rx_queue;
> > +	if (p_rx->set_prod_addr == NULL)
> > +		return -EIO;
> 
> Please use !p_rx->set_prod_addr as suggested by checkpatch

Sure, will be fixed in V2.