netdev - Re: [PATCH v2] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVSWks7f31O3y4QuZLnztoQgG04CuCiZ9Beo-qKezNmbw@mail.gmail.com>
Date:   Thu, 12 Aug 2021 10:27:09 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2] dt-bindings: net: renesas,etheravb: Document Gigabit
 Ethernet IP

Hi Biju,

On Tue, Jul 27, 2021 at 2:35 PM Biju Das <biju.das.jz@...renesas.com> wrote:
> Document Gigabit Ethernet IP found on RZ/G2L SoC.
>
> Gigabit Ethernet Interface includes Ethernet controller (E-MAC),
> Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory
> access controller (DMAC) for transferring transmitted Ethernet
> frames to and received Ethernet frames from respective storage
> areas in the URAM at high speed.
>
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml

> @@ -145,14 +142,20 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: renesas,etheravb-rcar-gen2
> +            enum:
> +              - renesas,etheravb-rcar-gen2
> +              - renesas,rzg2l-gbeth
>      then:
>        properties:
>          interrupts:
> -          maxItems: 1
> +          minItems: 1
> +          maxItems: 3
>          interrupt-names:
> +          minItems: 1
>            items:
>              - const: mux
> +            - const: int_fil_n
> +            - const: int_arp_ns_n

I'm aware Rob has already applied this, but should the "int_" prefix
be dropped?
The "_n" suffix is also a bit weird (albeit it matches the
documentation). Usually it is used to indicate an active-low signal,
but the interrupt is declared in the .dtsi with IRQ_TYPE_LEVEL_HIGH.

And the first interrupt is not a mux on RZ/G2L, but called "pif_int_n"
(whatever "pif" might mean).

>          rx-internal-delay-ps: false
>      else:
>        properties:

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds