netdev - Re: [PATCH net-next 1/2] net: dsa: print more information when a cross-chip notifier fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa4245b9-5e6f-0d60-d1ee-6bf8326501a4@gmail.com>
Date:   Thu, 12 Aug 2021 01:36:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 1/2] net: dsa: print more information when a
 cross-chip notifier fails



On 8/11/2021 6:46 AM, Vladimir Oltean wrote:
> Currently this error message does not say a lot:
> 
> [   32.693498] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> [   32.699725] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> [   32.705931] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> [   32.712139] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> [   32.718347] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> [   32.724554] DSA: failed to notify tag_8021q VLAN deletion: -ENOENT
> 
> but in this form, it is immediately obvious (at least to me) what the
> problem is, even without further looking at the code:
> 
> [   12.345566] sja1105 spi2.0: port 0 failed to notify tag_8021q VLAN 1088 deletion: -ENOENT
> [   12.353804] sja1105 spi2.0: port 0 failed to notify tag_8021q VLAN 2112 deletion: -ENOENT
> [   12.362019] sja1105 spi2.0: port 1 failed to notify tag_8021q VLAN 1089 deletion: -ENOENT
> [   12.370246] sja1105 spi2.0: port 1 failed to notify tag_8021q VLAN 2113 deletion: -ENOENT
> [   12.378466] sja1105 spi2.0: port 2 failed to notify tag_8021q VLAN 1090 deletion: -ENOENT
> [   12.386683] sja1105 spi2.0: port 2 failed to notify tag_8021q VLAN 2114 deletion: -ENOENT
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian