netdev - Re: [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210814092231.23513631@hermes.local>
Date:   Sat, 14 Aug 2021 09:22:31 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Gokul Sivakumar <gokulkumar792@...il.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev"
 & "dst" keywords in "bridge -c fdb"

On Sat, 14 Aug 2021 15:24:38 +0530
Gokul Sivakumar <gokulkumar792@...il.com> wrote:

> +	if (!filter_index && r->ndm_ifindex) {
> +		if (!is_json_context())
> +			fprintf(fp, "dev ");

This looks functionally correct, but please use:
            print_string(PRINT_FP, NULL, "dev ", NULL);

The reason as part of the json conversions I look for fprintf(fp
as indicator of unconverted code.