netdev - Re: [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed7f6a42edb01c203e1d6321124184820a23f1d0.camel@gmail.com>
Date:   Sun, 15 Aug 2021 00:16:12 +0530
From:   Gokul Sivakumar <gokulkumar792@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev"
 & "dst" keywords in "bridge -c fdb"

On Sat, 2021-08-14 at 09:22 -0700, Stephen Hemminger wrote:
> On Sat, 14 Aug 2021 15:24:38 +0530
> Gokul Sivakumar <gokulkumar792@...il.com> wrote:
> 
> > +	if (!filter_index && r->ndm_ifindex) {
> > +		if (!is_json_context())
> > +			fprintf(fp, "dev ");
> 
> This looks functionally correct, but please use:
>             print_string(PRINT_FP, NULL, "dev ", NULL);
> 
> The reason as part of the json conversions I look for fprintf(fp
> as indicator of unconverted code.

Ok, thanks for the review. I will send an updated v2 patchset now
with the 2 newly added fprintf() calls replaced by print_string().