netdev - Re: [PATCH iproute2-next v2 1/3] bridge: reorder cmd line arg parsing to let "-c" detected as "color" option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a6f29cb5d3240bc880e48a88f1b603e1f081c3a.camel@gmail.com>
Date:   Tue, 17 Aug 2021 22:47:18 +0530
From:   Gokul Sivakumar <gokulkumar792@...il.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next v2 1/3] bridge: reorder cmd line arg
 parsing to let "-c" detected as "color" option

On Tue, 2021-08-17 at 09:11 -0600, David Ahern wrote:
> On 8/14/21 12:47 PM, Gokul Sivakumar wrote:
> > As per the man/man8/bridge.8 page, the shorthand cmd line arg "-c" can be
> > used to colorize the bridge cmd output. But while parsing the args in while
> > loop, matches() detects "-c" as "-compressedvlans" instead of "-color", so
> > fix this by doing the check for "-color" option first before checking for
> > "-compressedvlans".
> > 
> > Signed-off-by: Gokul Sivakumar <gokulkumar792@...il.com>
> > ---
> >  bridge/bridge.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/bridge/bridge.c b/bridge/bridge.c
> > index f7bfe0b5..48b0e7f8 100644
> > --- a/bridge/bridge.c
> > +++ b/bridge/bridge.c
> > @@ -149,9 +149,9 @@ main(int argc, char **argv)
> >  			NEXT_ARG();
> >  			if (netns_switch(argv[1]))
> >  				exit(-1);
> > +		} else if (matches_color(opt, &color)) {
> >  		} else if (matches(opt, "-compressvlans") == 0) {
> >  			++compress_vlans;
> > -		} else if (matches_color(opt, &color)) {
> >  		} else if (matches(opt, "-force") == 0) {
> >  			++force;
> >  		} else if (matches(opt, "-json") == 0) {
> > 
> 
> Another example of why matches needs to be deprecated.
> 
> Re-assigned the set to Stephen for main tree.

Thanks, i will send a v3 patchset with the subject prefix "PATCH iproute2"
instead of "PATCH iproute2-next" after addressing Stephen's recent suggestion 
to remove the unnecessary is_json_context() condition checks from patch 2/3.

Gokul