netdev - Re: [PATCH iproute2-next v2 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79825fa723b291f09d4e65dc9c3b2159c7985cbc.camel@gmail.com>
Date:   Tue, 17 Aug 2021 22:52:35 +0530
From:   Gokul Sivakumar <gokulkumar792@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next v2 2/3] bridge: fdb: don't colorize the
 "dev" & "dst" keywords in "bridge -c fdb"

On Tue, 2021-08-17 at 08:27 -0700, Stephen Hemminger wrote:
> On Sun, 15 Aug 2021 00:17:26 +0530
> Gokul Sivakumar <gokulkumar792@...il.com> wrote:
> 
> > +		if (!is_json_context())
> > +			print_string(PRINT_FP, NULL, "dev ", NULL);
> 
> Why not the check for is_json_context is unnecessary here.
> That is what PRINT_FP does.

Thanks for pointing it out, will remove those two unnecessary
condition checks and send a v3 patchset now.

Gokul