netdev - Re: [PATCH 1/2] dt-bindings:dp83867:Add binding for the status led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRwEacEuiAuPzA0E@robh.at.kernel.org>
Date:   Tue, 17 Aug 2021 13:48:09 -0500
From:   Rob Herring <robh@...nel.org>
To:     chaochao2021666@....com
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chao Zeng <chao.zeng@...mens.com>
Subject: Re: [PATCH 1/2] dt-bindings:dp83867:Add binding for the status led

On Mon, Aug 09, 2021 at 04:52:13PM +0800, chaochao2021666@....com wrote:
> From: Chao Zeng <chao.zeng@...mens.com>
> 
> The phy status led of each of board maybe different.
> Provide a method to custom phy status led behavior.
> 
> Datasheet:
> http://www.ti.com/product/DP83867IR/datasheet
> 
> Signed-off-by: Chao Zeng <chao.zeng@...mens.com>
> ---
>  .../devicetree/bindings/net/ti,dp83867.yaml    |  6 ++++++
>  include/dt-bindings/net/ti-dp83867.h           | 18 ++++++++++++++++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> index 047d757e8d82..a46a437818f2 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -106,6 +106,12 @@ properties:
>        Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable
>        values.
>  
> +  ti,led-sel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      This configure the status led. See dt-bindings/net/ti-dp83867.h
> +      for different status led settings,select different configures

There's ongoing discussions about using the LED bindings/subsystem for 
this type of LED.

Rob