netdev - Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210817194448.tyg723667ql4kjvu@skbuf>
Date:   Tue, 17 Aug 2021 22:44:48 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Aleksander Jan Bajkowski <olek2@...pl>
Cc:     hauke@...ke-m.de, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay

On Tue, Aug 17, 2021 at 09:32:07PM +0200, Aleksander Jan Bajkowski wrote:
> The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> this patch, some phys are sometimes not properly detected.
> 
> Fixes: a09d042b086202735c4ed64 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Tested-by: Aleksander Jan Bajkowski <olek2@...pl> # tested on DWR966, HH5A
> ---

Generally the convention is:

From: Patch Author <patch.author@...il.com>

Commit description

Signed-off-by: Patch Author <patch.author@...il.com>
Signed-off-by: Patch Carrier 1 <patch.carrier1@...il.com>
Signed-off-by: Patch Carrier 2 <patch.carrier2@...il.com>
Signed-off-by: Patch Carrier 3 <patch.carrier3@...il.com>
Signed-off-by: Patch Submitter <patch.submitter@...il.com>

This patch is clearly not following this model for more than one reason.