netdev - Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210817202141.xddw5c7mypodnqlk@skbuf>
Date:   Tue, 17 Aug 2021 23:21:41 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Aleksander Jan Bajkowski <olek2@...pl>
Cc:     hauke@...ke-m.de, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay

On Tue, Aug 17, 2021 at 10:44:48PM +0300, Vladimir Oltean wrote:
> On Tue, Aug 17, 2021 at 09:32:07PM +0200, Aleksander Jan Bajkowski wrote:
> > The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> > this patch, some phys are sometimes not properly detected.
> > 
> > Fixes: a09d042b086202735c4ed64 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> > Tested-by: Aleksander Jan Bajkowski <olek2@...pl> # tested on DWR966, HH5A
> > ---
> 
> Generally the convention is:
> 
> From: Patch Author <patch.author@...il.com>
> 
> Commit description
> 
> Signed-off-by: Patch Author <patch.author@...il.com>
> Signed-off-by: Patch Carrier 1 <patch.carrier1@...il.com>
> Signed-off-by: Patch Carrier 2 <patch.carrier2@...il.com>
> Signed-off-by: Patch Carrier 3 <patch.carrier3@...il.com>
> Signed-off-by: Patch Submitter <patch.submitter@...il.com>
> 
> This patch is clearly not following this model for more than one reason.

Let's not even talk about the kilometer-long commit sha1sum.
This is not even my pet peeve, if this patch gets merged as-is you'll
get an email titled "linux-next: Fixes tag needs some work in the net tree"
(google it if you want examples).

Stick this in your ~/.gitconfig and thank me later:

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")

Now run:

git show a09d042b086202735c4ed64 --pretty=fixes
Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")

Voila!