netdev - Re: [PATCH net-next 0/3] Plug holes in DSA's software bridging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210823194545.5lczueo6jspu23u6@skbuf>
Date:   Mon, 23 Aug 2021 22:45:45 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 0/3] Plug holes in DSA's software bridging
 support

On Mon, Aug 23, 2021 at 09:02:39PM +0300, Vladimir Oltean wrote:
> This series addresses some oddities reported by Alvin while he was
> working on the new rtl8365mb driver (a driver which does not implement
> bridge offloading for now, and relies on software bridging).

I will resubmit for 3 reasons:

- I left an unused variable:
  https://patchwork.hopto.org/static/nipa/536059/12453371/build_32bit/stderr

- After wrapping up the testing with unoffloaded bridge ports I got a
  kernel panic when rebooting the board. This is because in
  dsa_port_pre_bridge_leave we call switchdev_bridge_port_unoffload on a
  NULL brport_dev. We must only call switchdev_bridge_port_unoffload if
  dp->bridge_dev is not NULL.

- I need to correct this phrase in the commit message of patch 2:
  | In turn, having dp->bridge_dev = NULL makes the following things go wrong:
                                  ~~~
                                  != NULL