netdev - Re: [PATCH] ptp: ocp: don't allow on S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Aug 2021 14:48:00 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Richard Cochran <richardcochran@...il.com>,
        Arnd Bergmann <arnd@...nel.org>
Cc:     Networking <netdev@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Subject: Re: [PATCH] ptp: ocp: don't allow on S390

On 8/20/21 8:31 AM, Richard Cochran wrote:
> On Fri, Aug 20, 2021 at 12:45:42PM +0200, Arnd Bergmann wrote:
> 
>> I would also suggest removing all the 'imply' statements, they
>> usually don't do what the original author intended anyway.
>> If there is a compile-time dependency with those drivers,
>> it should be 'depends on', otherwise they can normally be
>> left out.
> 
> +1

Hi,

Removing the "imply" statements is simple enough and the driver
still builds cleanly without them, so Yes, they aren't needed here.

Removing the SPI dependency is also clean.

The driver does use I2C, MTD, and SERIAL_8250 interfaces, so they
can't be removed without some other driver changes, like using
#ifdef/#endif (or #if IS_ENABLED()) blocks and some function stubs.

-- 
~Randy