netdev - Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSfm7zKz5BTNUXDz@lunn.ch>
Date:   Thu, 26 Aug 2021 21:09:35 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Biju Das <biju.das.jz@...renesas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Adam Ford <aford173@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>
Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct
 ravb_hw_info

On Thu, Aug 26, 2021 at 10:02:07PM +0300, Sergey Shtylyov wrote:
> On 8/26/21 9:57 PM, Andrew Lunn wrote:
> 
> >>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC mode register(CCC) present only in R-Car Gen3?
> >>
> >>    Yes.
> >>    But you feature naming is totally misguiding, nevertheless...
> > 
> > It can still be changed.
> 
>     Thank goodness, yea!

We have to live with the first version of this in the git history, but
we can add more patches fixing up whatever is broken in the unreviewed
code which got merged.

> > Just suggest a new name.
> 
>     I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for the gPTP working also in CONFIG mode
> (CCC.GAC controls this feature).

Biju, please could you work on a couple of patches to change the names.

I also suggest you post further refactoring patches as RFC. We might
get a chance to review them then.

    Andrew