netdev - RE: [PATCH net-next 06/13] ravb: Factorise ravb_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB59228C3EDA5A6D01504169F486C79@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Thu, 26 Aug 2021 19:34:00 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Andrew Lunn <andrew@...n.ch>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Adam Ford <aford173@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>
Subject: RE: [PATCH net-next 06/13] ravb: Factorise ravb_ring_format function

Hi Sergei,

> Subject: Re: [PATCH net-next 06/13] ravb: Factorise ravb_ring_format
> function
> 
> On 8/25/21 10:01 AM, Biju Das wrote:
> 
> > The ravb_ring_format function uses an extended descriptor in RX for
> > R-Car compared to the normal descriptor for RZ/G2L. Factorise RX ring
> > buffer buildup to extend the support for later SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> [...]
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index dc388a32496a..e52e36ccd1c6 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> [...]
> > @@ -321,6 +310,26 @@ static void ravb_ring_format(struct net_device
> *ndev, int q)
> >  	rx_desc = &priv->rx_ring[q][i];
> >  	rx_desc->dptr = cpu_to_le32((u32)priv->rx_desc_dma[q]);
> >  	rx_desc->die_dt = DT_LINKFIX; /* type */
> > +}
> > +
> > +/* Format skb and descriptor buffer for Ethernet AVB */ static void
> > +ravb_ring_format(struct net_device *ndev, int q) {
> > +	struct ravb_private *priv = netdev_priv(ndev);
> > +	const struct ravb_hw_info *info = priv->info;
> > +	unsigned int num_tx_desc = priv->num_tx_desc;
> > +	struct ravb_tx_desc *tx_desc;
> > +	struct ravb_desc *desc;
> > +	unsigned int tx_ring_size = sizeof(*tx_desc) * priv->num_tx_ring[q]
> *
> > +				    num_tx_desc;
> > +	unsigned int i;
> > +
> > +	priv->cur_rx[q] = 0;
> > +	priv->cur_tx[q] = 0;
> > +	priv->dirty_rx[q] = 0;
> > +	priv->dirty_tx[q] = 0;
> > +
> > +	info->rx_ring_format(ndev, q);
> >
> >  	memset(priv->tx_ring[q], 0, tx_ring_size);
> >  	/* Build TX ring buffer */
> 
>    That's all fine but the fragment that sets up TX descriptor ring base
> address was left in ravb_rx_ring_formet()...

Can you please clarify this? Which fragment in [1]? Do you see any problems with that?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/ethernet/renesas/ravb_main.c#n286

Regards,
Biju


Regards,
Biju