| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210826193922.66204-20-jolsa@kernel.org>
Date: Thu, 26 Aug 2021 21:39:14 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andriin@...com>,
"Steven Rostedt (VMware)" <rostedt@...dmis.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...omium.org>, Daniel Xu <dxu@...uu.xyz>,
Viktor Malik <vmalik@...hat.com>
Subject: [PATCH bpf-next v4 19/27] bpf: Attach multi trampoline with ftrace_ops
Adding struct ftrace_ops object to bpf_trampoline_multi
struct and setting it up with all the requested function
addresses.
Adding is_multi_trampoline(tr) hooks to installing functions
to actually install multiple bpf trampoline via ftrace_ops.
I had to add -DCC_USING_FENTRY to several places because
arch/x86/include/asm/ftrace.h would fail the compilation
if it's not defined. Perhaps there's a better way.
Signed-off-by: Jiri Olsa <jolsa@...nel.org>
---
arch/x86/Makefile | 7 +++++
arch/x86/boot/compressed/Makefile | 4 +++
drivers/firmware/efi/libstub/Makefile | 3 +++
include/linux/bpf.h | 2 ++
kernel/bpf/trampoline.c | 37 +++++++++++++++++++++++++++
5 files changed, 53 insertions(+)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 307fd0000a83..72986eb38d0b 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -34,6 +34,9 @@ REALMODE_CFLAGS += -fno-stack-protector
REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -Wno-address-of-packed-member)
REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), $(cc_stack_align4))
REALMODE_CFLAGS += $(CLANG_FLAGS)
+ifdef CONFIG_DYNAMIC_FTRACE
+ REALMODE_CFLAGS += -DCC_USING_FENTRY
+endif
export REALMODE_CFLAGS
# BITS is used as extension for files which are available in a 32 bit
@@ -54,6 +57,10 @@ KBUILD_CFLAGS += $(call cc-option,-mno-avx,)
# Intel CET isn't enabled in the kernel
KBUILD_CFLAGS += $(call cc-option,-fcf-protection=none)
+ifdef CONFIG_DYNAMIC_FTRACE
+ KBUILD_CFLAGS += -DCC_USING_FENTRY
+endif
+
ifeq ($(CONFIG_X86_32),y)
BITS := 32
UTS_MACHINE := i386
diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index 431bf7f846c3..a93dcbda4de2 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -49,6 +49,10 @@ KBUILD_CFLAGS += $(call as-option,-Wa$(comma)-mrelax-relocations=no)
KBUILD_CFLAGS += -include $(srctree)/include/linux/hidden.h
KBUILD_CFLAGS += $(CLANG_FLAGS)
+ifdef CONFIG_DYNAMIC_FTRACE
+ KBUILD_CFLAGS += -DCC_USING_FENTRY
+endif
+
# sev.c indirectly inludes inat-table.h which is generated during
# compilation and stored in $(objtree). Add the directory to the includes so
# that the compiler finds it even with out-of-tree builds (make O=/some/path).
diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index d0537573501e..2fd5d6f55e24 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -15,6 +15,9 @@ cflags-$(CONFIG_X86) += -m$(BITS) -D__KERNEL__ \
$(call cc-disable-warning, gnu) \
-fno-asynchronous-unwind-tables \
$(CLANG_FLAGS)
+ifdef CONFIG_DYNAMIC_FTRACE
+ cflags-$(CONFIG_X86) += -DCC_USING_FENTRY
+endif
# arm64 uses the full KBUILD_CFLAGS so it's necessary to explicitly
# disable the stackleak plugin
diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index 373f45ae7dce..52cbec23665c 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -23,6 +23,7 @@
#include <linux/slab.h>
#include <linux/percpu-refcount.h>
#include <linux/bpfptr.h>
+#include <linux/ftrace.h>
struct bpf_verifier_env;
struct bpf_verifier_log;
@@ -703,6 +704,7 @@ struct bpf_trampoline_multi {
struct list_head list;
u32 *ids;
u32 ids_cnt;
+ struct ftrace_ops ops;
int tr_cnt;
struct bpf_trampoline *tr[];
};
diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c
index 308d58e698be..82e7545a7426 100644
--- a/kernel/bpf/trampoline.c
+++ b/kernel/bpf/trampoline.c
@@ -179,11 +179,38 @@ static int is_ftrace_location(void *ip)
return 1;
}
+static int register_ftrace_multi(struct bpf_trampoline *tr, void *new_addr)
+{
+ struct bpf_trampoline_multi *multi;
+
+ multi = container_of(tr, struct bpf_trampoline_multi, main);
+ return register_ftrace_direct_multi(&multi->ops, (long)new_addr);
+}
+
+static int unregister_ftrace_multi(struct bpf_trampoline *tr, void *old_addr)
+{
+ struct bpf_trampoline_multi *multi;
+
+ multi = container_of(tr, struct bpf_trampoline_multi, main);
+ return unregister_ftrace_direct_multi(&multi->ops);
+}
+
+static int modify_ftrace_multi(struct bpf_trampoline *tr, void *new_addr)
+{
+ struct bpf_trampoline_multi *multi;
+
+ multi = container_of(tr, struct bpf_trampoline_multi, main);
+ return modify_ftrace_direct_multi(&multi->ops, (long)new_addr);
+}
+
static int unregister_fentry(struct bpf_trampoline *tr, void *old_addr)
{
void *ip = tr->func.addr;
int ret;
+ if (is_multi_trampoline(tr))
+ return unregister_ftrace_multi(tr, old_addr);
+
if (tr->func.ftrace_managed)
ret = unregister_ftrace_direct((long)ip, (long)old_addr);
else
@@ -199,6 +226,9 @@ static int modify_fentry(struct bpf_trampoline *tr, void *old_addr, void *new_ad
void *ip = tr->func.addr;
int ret;
+ if (is_multi_trampoline(tr))
+ return modify_ftrace_multi(tr, new_addr);
+
if (tr->func.ftrace_managed)
ret = modify_ftrace_direct((long)ip, (long)old_addr, (long)new_addr);
else
@@ -212,6 +242,9 @@ static int register_fentry(struct bpf_trampoline *tr, void *new_addr)
void *ip = tr->func.addr;
int ret;
+ if (is_multi_trampoline(tr))
+ return register_ftrace_multi(tr, new_addr);
+
ret = is_ftrace_location(ip);
if (ret < 0)
return ret;
@@ -703,6 +736,10 @@ struct bpf_trampoline_multi *bpf_trampoline_multi_get(struct bpf_prog *prog,
if (!is_ftrace_location((void *) tgt_info.tgt_addr))
goto out_free;
+ err = ftrace_set_filter_ip(&multi->ops, tgt_info.tgt_addr, 0, 0);
+ if (err)
+ goto out_free;
+
if (nr_args < tgt_info.fmodel.nr_args)
nr_args = tgt_info.fmodel.nr_args;
}
--
2.31.1
Powered by blists - more mailing lists