netdev - Re: Question about inet_rtm_getroute_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bdb1675-7520-8d97-4386-20e2235368df@gmail.com>
Date:   Fri, 27 Aug 2021 08:09:39 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Ahern <dsahern@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Networking <netdev@...r.kernel.org>,
        Roopa Prabhu <roopa@...dia.com>
Subject: Re: Question about inet_rtm_getroute_build_skb()



On 8/26/21 9:37 PM, David Ahern wrote:
> On 8/26/21 6:16 PM, Eric Dumazet wrote:
>> Hi Roopa
>>
>> I noticed inet_rtm_getroute_build_skb() has this endian issue 
>> when building an UDP header.
>>
>> Would the following fix break user space ?
> 
> I do not see how. As I recall this is only for going through
> ip_route_input_rcu and ip_route_output_key_hash_rcu and a call to
> fib4_rules_early_flow_dissect.
> 

Ah, nice !

Could we add a test for this feature ?
I could not really figure out reading the commit changelog how this stuff was used.