netdev - Re: sunxi H5 DTB fix for realtek regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSziXfll/p/5OrOv@lunn.ch>
Date:   Mon, 30 Aug 2021 15:51:25 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Clément Bœsch <u@....me>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Willy Liu <willy.liu@...ltek.com>, netdev@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: sunxi H5 DTB fix for realtek regression

On Mon, Aug 30, 2021 at 02:52:57AM +0200, Clément Bœsch wrote:
> Hi,
> 
> Commit bbc4d71d63549bcd003a430de18a72a742d8c91e ("net: phy: realtek: fix
> rtl8211e rx/tx delay config") broke the network on the NanoPI NEO 2 board
> (RTL8211E chip).
> 
> Following what was suggested by Andrew Lunn for another hardware¹, I tried
> the following diff:
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> index 02f8e72f0cad..05486cccee1c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> @@ -75,7 +75,7 @@ &emac {
>         pinctrl-0 = <&emac_rgmii_pins>;
>         phy-supply = <&reg_gmac_3v3>;
>         phy-handle = <&ext_rgmii_phy>;
> -       phy-mode = "rgmii";
> +       phy-mode = "rgmii-id";
>         status = "okay";
>  };
> 
> 
> ...which fixed the issue. This was tested on v5.11.4 but the patch applies
> cleanly on stable so far.
> 
> I'm sorry for not sending a proper patch: I unfortunately have very little
> clue about what I'm doing here so it's very hard for me to elaborate a
> proper commit description.

Hi Clément

You are not too far away from a proper patch. I can either guide you,
if you want to learn, or the allwinner maintainer can probably take
your work and finish it off.

     Andrew