netdev - Re: sunxi H5 DTB fix for realtek regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSzsmy1f2//NNzXm@ssq0.pkh.me>
Date:   Mon, 30 Aug 2021 16:35:07 +0200
From:   Clément Bœsch <u@....me>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Willy Liu <willy.liu@...ltek.com>, netdev@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: sunxi H5 DTB fix for realtek regression

On Mon, Aug 30, 2021 at 03:51:25PM +0200, Andrew Lunn wrote:
[...]
> > I'm sorry for not sending a proper patch: I unfortunately have very little
> > clue about what I'm doing here so it's very hard for me to elaborate a
> > proper commit description.
> 
> Hi Clément
> 
> You are not too far away from a proper patch. I can either guide you,
> if you want to learn, or the allwinner maintainer can probably take
> your work and finish it off.

See attached patch, heavily based on other commits.

Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might
affect other hardware as well. I don't know how one is supposed to check
that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a
quick internet search shows that it's using a RTL8211E¹)

The grep returns 231 occurences... A lot of other boards might have a
broken network right now.

[1]: http://nanopi.io/nanopi-a64.html

-- 
Clément B.

View attachment "0001-arm64-dts-sun50i-h5-NanoPI-Neo-2-phy-mode-rgmii-id.patch" of type "text/plain" (1190 bytes)