netdev - Re: sunxi H5 DTB fix for realtek regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSzzuDvd1fWXxcAb@lunn.ch>
Date:   Mon, 30 Aug 2021 17:05:28 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Clément Bœsch <u@....me>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Willy Liu <willy.liu@...ltek.com>, netdev@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: sunxi H5 DTB fix for realtek regression

> See attached patch, heavily based on other commits.

Looks good.

You need to add a Signed-off-by: See

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Patches need to be in the body of the email, not attachments.

You can use scripts/get_maintainers.pl to get a list of people to send
it to. I would use To: for
Maxime Ripard <mripard@...nel.org> (maintainer:ARM/Allwinner sunXi SoC support)
Chen-Yu Tsai <wens@...e.org> (maintainer:ARM/Allwinner sunXi SoC support)
Jernej Skrabec <jernej.skrabec@...il.com> (reviewer:ARM/Allwinner sunXi SoC support)

and Cc: for the rest.

> Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might
> affect other hardware as well.

"rgmii" can be correct. So you need to narrow your search.

> I don't know how one is supposed to check
> that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a
> quick internet search shows that it's using a RTL8211E¹)

This seems reasonable. You could provide a second patch for this.

     Andrew