netdev - Re: [PATCH v2 05/14] [net-next] cs89x0: rework driver configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210901171957.GA2882691@roeck-us.net>
Date:   Wed, 1 Sep 2021 10:19:57 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     netdev@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrew Lunn <andrew@...n.ch>, Andrii Nakryiko <andriin@...com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Doug Berger <opendmb@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Finn Thain <fthain@...egraphics.com.au>,
        Florian Fainelli <f.fainelli@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jakub Kicinski <kuba@...nel.org>, Jessica Yu <jeyu@...nel.org>,
        Michael Schmitz <schmitzmic@...il.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Sam Creasey <sammy@...my.net>, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2 05/14] [net-next] cs89x0: rework driver configuration

On Tue, Aug 03, 2021 at 01:40:42PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> There are two drivers in the cs89x0 file, with the CONFIG_CS89x0_PLATFORM
> symbol deciding which one is getting built. This is somewhat confusing
> and makes it more likely ton configure a driver that works nowhere.
> 
> Split up the Kconfig option into separate ISA and PLATFORM drivers,
> with the ISA symbol explicitly connecting to the static probing in
> drivers/net/Space.c
> 
> The two drivers are still mutually incompatible at compile time,
> which could be lifted by splitting them into multiple files,
> but in practice this will make no difference.
> 
> The platform driver can now be enabled for compile-testing on
> non-ARM machines.
> 

powerpc:allmodconfig in mainline (I tested v5.14-3756-gd8b4266666c4 and
v5.14-4526-gebf435d3b51b):

drivers/net/ethernet/cirrus/cs89x0.c: In function 'net_open':
drivers/net/ethernet/cirrus/cs89x0.c:897:41: error: implicit declaration of function 'isa_virt_to_bus'

Guenter