netdev - Re: [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba35e7b8-4f90-9870-3e9e-f8666f5ebd0f@gmail.com>
Date:   Wed, 1 Sep 2021 10:21:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        stable@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the
 DSA struct



On 9/1/2021 2:21 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Setting DSA_MAX_PORTS caused DSA to call b53 callbacks (e.g.
> b53_disable_port() during dsa_register_switch()) for invalid
> (non-existent) ports. That made b53 modify unrelated registers and is
> one of reasons for a broken BCM5301x support.
> 
> This problem exists for years but DSA_MAX_PORTS usage has changed few
> times so it's hard to specify a single commit this change fixes.

You should still try to identify the relevant tags that this is fixing 
such that this gets back ported to the appropriate trees. We could use 
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper"), to 
minimize the amount of work doing the back port.
-- 
Florian