netdev - Re: [PATCH] wireless: ath5k: Remove unnecessary label of ath5k_beacon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Sep 2021 10:48:55 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     dingsenjie@....com
Cc:     jirislaby@...nel.org, mickflemm@...il.com, kvalo@...eaurora.org,
        davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dingsenjie <dingsenjie@...ong.com>
Subject: Re: [PATCH] wireless: ath5k: Remove unnecessary label of
 ath5k_beacon_update

On Fri, Sep 03, 2021 at 02:23:16PM +0800, dingsenjie@....com wrote:
> From: dingsenjie <dingsenjie@...ong.com>
> 
> The label just used as return, so we delete it and
> use the return statement instead of the goto statement.
> 
> Signed-off-by: dingsenjie <dingsenjie@...ong.com>
> ---
>  drivers/net/wireless/ath/ath5k/base.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index 4c6e57f..9739189 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1896,23 +1896,18 @@ static int ath5k_remove_padding(struct sk_buff *skb)
>  	struct ath5k_vif *avf;
>  	struct sk_buff *skb;

Just initialize ret = -EINVAL at the top, and you to get clear out a few
braces which are not needed anymore. Anyway, this code is not reflected
on linux-next, what codebase are you using? If the code change is just
a cleanup it should remove more code than add, and a commmit log should
reflect that clearly.

  Luis