netdev - RE: [PATCH bpf-next 01/20] selftests: xsk: simplify xsk and umem arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6132613457747_1c226208a0@john-XPS-13-9370.notmuch>
Date:   Fri, 03 Sep 2021 10:53:56 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>,
        magnus.karlsson@...el.com, bjorn@...nel.org, ast@...nel.org,
        daniel@...earbox.net, netdev@...r.kernel.org,
        maciej.fijalkowski@...el.com
Cc:     jonathan.lemon@...il.com, ciara.loftus@...el.com,
        bpf@...r.kernel.org, yhs@...com, andrii@...nel.org
Subject: RE: [PATCH bpf-next 01/20] selftests: xsk: simplify xsk and umem
 arrays

Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@...el.com>
> 
> Simplify the xsk_info and umem_info allocation by allocating them
> upfront in an array, instead of allocating an array of pointers to
> future creations of these. Allocating them upfront also has the
> advantage that configuration information can be stored in these
> structures instead of relying on global variables. With the previous
> structure, xsk_info and umem_info were created too late to be able to
> store most configuration information. This will be used to eliminate
> most global variables in later patches in this series.
> 
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>