netdev - Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <882b37d0-5e3a-2453-c9f1-827de127bd01@infradead.org>
Date:   Sun, 12 Sep 2021 15:15:17 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Adam Borowski <kilobyte@...band.pl>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        David Howells <dhowells@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

On 9/12/21 2:23 PM, Adam Borowski wrote:
> It was used but never set.  The hardcoded value from before the dawn of
> time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL
> 
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
>   This is neither the host nor target arch, thus it's very unlikely to be
>   set by the user.  With this patch, it works out of the box on Debian
>   and Fedora.
> 
>   drivers/net/wan/Makefile | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
> index f6b92efffc94..480bcd1f6c1c 100644
> --- a/drivers/net/wan/Makefile
> +++ b/drivers/net/wan/Makefile
> @@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
>   clean-files := wanxlfw.inc
>   $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
>   
> +CROSS_COMPILE_M68K = m68k-linux-gnu-
> +
>   ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
>   ifeq ($(ARCH),m68k)
>     M68KCC = $(CC)
> 

Just curious: why is all of that M68K/m68k stuff
even in this makefile?

thanks.
-- 
~Randy