netdev - Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210914200749.018391a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 14 Sep 2021 20:07:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Masahiro Yamada <masahiroy@...nel.org>,
        David Howells <dhowells@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

On Sun, 12 Sep 2021 23:23:21 +0200 Adam Borowski wrote:
> It was used but never set.  The hardcoded value from before the dawn of
> time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL
> 
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
>  This is neither the host nor target arch, thus it's very unlikely to be
>  set by the user.  With this patch, it works out of the box on Debian
>  and Fedora.
> 
>  drivers/net/wan/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
> index f6b92efffc94..480bcd1f6c1c 100644
> --- a/drivers/net/wan/Makefile
> +++ b/drivers/net/wan/Makefile
> @@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
>  clean-files := wanxlfw.inc
>  $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
>  
> +CROSS_COMPILE_M68K = m68k-linux-gnu-

This will not overwrite the parameter if set from command line, right?
My Makefile-foo is getting rusty.

>  ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
>  ifeq ($(ARCH),m68k)
>    M68KCC = $(CC)