netdev - Re: [PATCH v2] include/uapi/linux/xfrm.h: Fix XFRM_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210913102316.GA30886@asgard.redhat.com>
Date:   Mon, 13 Sep 2021 12:23:16 +0200
From:   Eugene Syromiatnikov <esyr@...hat.com>
To:     Ondrej Mosnacek <omosnace@...hat.com>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Antony Antony <antony.antony@...unet.com>,
        Christian Langrock <christian.langrock@...unet.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        SElinux list <selinux@...r.kernel.org>,
        Paul Moore <paul@...l-moore.com>,
        Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>,
        network dev <netdev@...r.kernel.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        "Dmitry V. Levin" <ldv@...ace.io>,
        Linux API <linux-api@...r.kernel.org>
Subject: Re: [PATCH v2] include/uapi/linux/xfrm.h: Fix XFRM_MSG_MAPPING ABI
 breakage

On Mon, Sep 13, 2021 at 09:16:39AM +0200, Ondrej Mosnacek wrote:
> Perhaps it would be a good idea to put a comment here to make it less
> likely that this repeats in the future. Something like:
> 
> /* IMPORTANT: Only insert new entries right above this line, otherwise
> you break ABI! */

Well, this statement is true for (almost) every UAPI-exposed enum, and
netlink is vast and relies on enums heavily.  I think it is already
mentioned somewhere in the documentation, and in the end it falls on the
shoulders of the maintainers—to pay additional attention to UAPI changes.