netdev - Re: [PATCH] rsi: Fix module dev_oper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a19c659a-45c5-5e3c-f681-caaa55d085b6@denx.de>
Date:   Thu, 16 Sep 2021 16:39:06 +0200
From:   Marek Vasut <marex@...x.de>
To:     Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        netdev@...r.kernel.org
Cc:     Amitkumar Karwar <amit.karwar@...pinesignals.com>,
        Angus Ainslie <angus@...ea.ca>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Karun Eagalapati <karun256@...il.com>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Martin Kepplinger <martink@...teo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Siva Rebbagondla <siva8118@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] rsi: Fix module dev_oper_mode parameter description

On 9/16/21 9:03 AM, Sebastian Krzyszkowiak wrote:
> On środa, 15 września 2021 10:08:41 CEST Marek Vasut wrote:
>> +#define DEV_OPMODE_PARAM_DESC		\
>> +	__stringify(DEV_OPMODE_WIFI_ALONE)	"[Wi-Fi alone], "	\
>> +	__stringify(DEV_OPMODE_BT_ALONE)	"[BT classic alone], "	\
>> +	__stringify(DEV_OPMODE_BT_LE_ALONE)	"[BT LE], "		
> \
>> +	__stringify(DEV_OPMODE_BT_DUAL)		"[BT Dual], "		
> \
>> +	__stringify(DEV_OPMODE_STA_BT)		"[Wi-Fi STA + BT
> classic], " \
>> +	__stringify(DEV_OPMODE_STA_BT_LE)	"[Wi-Fi STA + BT LE], "	\
>> +	__stringify(DEV_OPMODE_STA_BT_DUAL)	"[Wi-Fi STA + BT
> classic + BT LE], " \
>> +	__stringify(DEV_OPMODE_AP_BT)		"[AP + BT classic], "	
> \
>> +	__stringify(DEV_OPMODE_AP_BT_DUAL)	"[AP + BT classic + BT LE]"
> 
> There's still some inconsistency in mode naming - how about:
> 
> - Wi-Fi STA

This mode is also AP capable

> - BT classic
> - BT LE
> - BT classic + BT LE
> - Wi-Fi STA + BT classic
> - Wi-Fi STA + BT LE
> - Wi-Fi STA + BT classic + BT LE
> - Wi-Fi AP + BT classic
> - Wi-Fi AP + BT classic + BT LE
> 
> "alone" could be added to the first three modes (you missed it in BT LE).

I can add the alone consistently, yes -- that's the point of the first 
three modes, that the "other" radio is disabled by the firmware.