netdev - Re: [PATCH] net: phy: dp83640: Drop unused PAGE0 define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b07c181-d039-eda0-d623-4e791bb2a43f@roeck-us.net>
Date:   Thu, 16 Sep 2021 13:10:53 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: dp83640: Drop unused PAGE0 define

On 9/16/21 12:50 PM, Guenter Roeck wrote:
> parisc:allmodconfig fails to build with the following error.
> 
> In file included from drivers/net/phy/dp83640.c:23:
> drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined
> 
> The dp83640 driver does not use this define, so just remove it.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>   drivers/net/phy/dp83640_reg.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83640_reg.h b/drivers/net/phy/dp83640_reg.h
> index 21aa24c741b9..601e8d107723 100644
> --- a/drivers/net/phy/dp83640_reg.h
> +++ b/drivers/net/phy/dp83640_reg.h
> @@ -5,7 +5,6 @@
>   #ifndef HAVE_DP83640_REGISTERS
>   #define HAVE_DP83640_REGISTERS
>   
> -#define PAGE0                     0x0000
>   #define PHYCR2                    0x001c /* PHY Control Register 2 */
>   
>   #define PAGE4                     0x0004
> 

Sorry for the noise. I just learned that the problem is already fixed.

Guenter