netdev - Re: [PATCH] rsi: Fix module dev_oper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fsu516d6.fsf@codeaurora.org>
Date:   Thu, 16 Sep 2021 07:39:33 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org,
        Amitkumar Karwar <amit.karwar@...pinesignals.com>,
        Angus Ainslie <angus@...ea.ca>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Karun Eagalapati <karun256@...il.com>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Martin Kepplinger <martink@...teo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>, stable@...r.kernel.org,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] rsi: Fix module dev_oper_mode parameter description

+ linux-wireless

Marek Vasut <marex@...x.de> writes:

> The module parameters are missing dev_oper_mode 12, BT classic alone,
> add it. Moreover, the parameters encode newlines, which ends up being
> printed malformed e.g. by modinfo, so fix that too.
>
> However, the module parameter string is duplicated in both USB and SDIO
> modules and the dev_oper_mode mode enumeration in those module parameters
> is a duplicate of macros used by the driver. Furthermore, the enumeration
> is confusing.
>
> So, deduplicate the module parameter string and use __stringify() to
> encode the correct mode enumeration values into the module parameter
> string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
> 'BT classic alone' to clarify what those modes really mean.
>
> Fixes: 898b255339310 ("rsi: add module parameter operating mode")
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Amitkumar Karwar <amit.karwar@...pinesignals.com>
> Cc: Angus Ainslie <angus@...ea.ca>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Karun Eagalapati <karun256@...il.com>
> Cc: Martin Fuzzey <martin.fuzzey@...wbird.group>
> Cc: Martin Kepplinger <martink@...teo.de>
> Cc: Prameela Rani Garnepudi <prameela.j04cs@...il.com>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
> Cc: Siva Rebbagondla <siva8118@...il.com>
> To: netdev@...r.kernel.org
> Cc: <stable@...r.kernel.org> # 4.17+
> ---
>  drivers/net/wireless/rsi/rsi_91x_sdio.c |  5 +----
>  drivers/net/wireless/rsi/rsi_91x_usb.c  |  5 +----
>  drivers/net/wireless/rsi/rsi_hal.h      | 11 +++++++++++
>  3 files changed, 13 insertions(+), 8 deletions(-)

linux-wireless is not included so patchwork won't see this patch. Please
resubmit (as v2) and include linux-wireless, more info in the wiki
below.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches