netdev - Re: [PATCH net-next] Revert "net: wwan: iosm: firmware flashing and coredump collection"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210915182830.554461ea@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 15 Sep 2021 18:28:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Kumar, M Chetan" <m.chetan.kumar@...el.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH net-next] Revert "net: wwan: iosm: firmware flashing and
 coredump collection"

On Wed, 15 Sep 2021 23:17:09 +0000 Kumar, M Chetan wrote:
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Thursday, September 16, 2021 3:28 AM
> > To: davem@...emloft.net
> > Cc: netdev@...r.kernel.org; loic.poulain@...aro.org; ryazanov.s.a@...il.com;
> > Kumar, M Chetan <m.chetan.kumar@...el.com>; Jakub Kicinski
> > <kuba@...nel.org>
> > Subject: [PATCH net-next] Revert "net: wwan: iosm: firmware flashing and
> > coredump collection"
> > 
> > The devlink parameters are not the right mechanism to pass
> > extra parameters to device flashing. The params added are
> > also undocumented.  
> 
> Could you please suggest us how should we pass extra parameters ?

Once you document them, we'll know what they are, why they are needed
etc.

> Also I was about to submit the patch for documentation!!

2 days later. I'd much rather have the code reverted and then 
it's on you to fix it, not on me to chase you.