netdev - Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210917125401.6e22ae13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 17 Sep 2021 12:54:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <min.li.xe@...esas.com>
Cc:     <richardcochran@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time
 correction

On Fri, 17 Sep 2021 10:39:49 -0400 min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
> 
> Current adjtime is not accurate when delta is smaller than 10000ns. So
> for small time correction, we will switch to DCO mode to pull phase
> more precisely in one second duration.
> 
> Signed-off-by: Min Li <min.li.xe@...esas.com>

Please fix the checkpatch issues.

> @@ -29,6 +29,14 @@ module_param(phase_snap_threshold, uint, 0);
>  MODULE_PARM_DESC(phase_snap_threshold,
>  "threshold (1000ns by default) below which adjtime would ignore");
>  
> +static bool delayed_accurate_adjtime = false;
> +module_param(delayed_accurate_adjtime, bool, false);
> +MODULE_PARM_DESC(delayed_accurate_adjtime,
> +"set to true to use more accurate adjtime that is delayed to next 1PPS signal");

Module parameters are discouraged. If you have multiple devices on the
system module parameters don't allow setting different options
depending on device. Unless Richard or someone else suggests a better
API for this please use something like devlink params instead
(and remember to document them).

> +static char *firmware;
> +module_param(firmware, charp, 0);

What's the point of this? Just rename the file in the filesystem.