netdev - Re: [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUTzVmf0W8/RjyK0@lunn.ch>
Date:   Fri, 17 Sep 2021 21:58:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     min.li.xe@...esas.com
Cc:     richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime

On Fri, Sep 17, 2021 at 10:39:48AM -0400, min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
> 
> The current adjtime implementation is read-modify-write and immediately
> triggered, which is not accurate due to slow i2c bus access. Therefore,
> we will use internally generated 1 PPS pulse as trigger, which will
> improve adjtime accuracy significantly. On the other hand, the new trigger
> will not change TOD immediately but delay it to the next 1 PPS pulse.
> 
> Signed-off-by: Min Li <min.li.xe@...esas.com>
> ---
>  drivers/ptp/ptp_idt82p33.c | 221 ++++++++++++++++++++++++++++++---------------
>  drivers/ptp/ptp_idt82p33.h |  28 +++---
>  2 files changed, 165 insertions(+), 84 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
> index c1c959f..abe628c 100644
> --- a/drivers/ptp/ptp_idt82p33.c
> +++ b/drivers/ptp/ptp_idt82p33.c
> @@ -24,15 +24,10 @@ MODULE_LICENSE("GPL");
>  MODULE_FIRMWARE(FW_FILENAME);
>  
>  /* Module Parameters */
> -static u32 sync_tod_timeout = SYNC_TOD_TIMEOUT_SEC;
> -module_param(sync_tod_timeout, uint, 0);
> -MODULE_PARM_DESC(sync_tod_timeout,
> -"duration in second to keep SYNC_TOD on (set to 0 to keep it always on)");
> -

Despite module parameters not being liked, they are probably also
considered ABI. So you probably cannot remove it.

	   Andrew