lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Sep 2021 22:39:47 -0700 From: Brendan Higgins <brendanhiggins@...gle.com> To: Arnd Bergmann <arnd@...db.de> Cc: Shuah Khan <skhan@...uxfoundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Naresh Kamboju <naresh.kamboju@...aro.org>, Mathias Nyman <mathias.nyman@...el.com>, Johannes Berg <johannes@...solutions.net>, Jakub Kicinski <kuba@...nel.org>, Ariel Elior <aelior@...vell.com>, GR-everest-linux-l2@...vell.com, Wei Liu <wei.liu@...nel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, lkft-triage@...ts.linaro.org, "David S. Miller" <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Nathan Chancellor <nathan@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, Eric Dumazet <edumazet@...gle.com>, KUnit Development <kunit-dev@...glegroups.com> Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] On Tue, Sep 14, 2021 at 3:04 PM Arnd Bergmann <arnd@...db.de> wrote: > > On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins > <brendanhiggins@...gle.com> wrote: > > > > On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan <skhan@...uxfoundation.org> wrote: > > > > > > On 9/8/21 3:24 PM, Brendan Higgins wrote: > > > Brendan, > > > > > > Would you like to send me the fix with Suggested-by for Arnd or Kees? > > > > So it looks like Arnd's fix was accepted (whether by him or someone > > else) for property-entry-test and Linus already fixed thunderbolt, so > > the only remaining of Arnd's patches is for the bitfield test, so I'll > > resend that one in a bit. > > > > Also, I haven't actually tried Linus' suggestion yet, but the logic is > > sound and the change *should* be fairly unintrusive - I am going to > > give that a try and report back (but I will get the bitfield > > structleak disable patch out first since I already got that applying). > > Looking at my randconfig tree, I find these six instances: > > $ git grep -w DISABLE_STRUCTLEAK_PLUGIN > drivers/base/test/Makefile:CFLAGS_property-entry-test.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/iio/test/Makefile:CFLAGS_iio-test-format.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/mmc/host/Makefile:CFLAGS_sdhci-of-aspeed.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/thunderbolt/Makefile:CFLAGS_test.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_test_scanf.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_bitfield_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN) > scripts/Makefile.gcc-plugins: DISABLE_STRUCTLEAK_PLUGIN += > -fplugin-arg-structleak_plugin-disable > scripts/Makefile.gcc-plugins:export DISABLE_STRUCTLEAK_PLUGIN Alright, I incorporated all the above into a patchset that I think is ready to send out, but I had a couple of issues with the above suggestions: - I could not find a config which causes a stacksize warning for sdhci-of-aspeed. - test_scanf is not a KUnit test. - Linus already fixed the thunderbolt test by breaking up the test cases. I am going to send out patches for the thunderbolt test and for the sdhci-of-aspeed test for the sake of completeness, but I am not sure if we should merge those two. I'll let y'all decide on the patch review. I only based the thunderbolt and bitfield test fixes on actual patches from Arnd, but I think Arnd pretty much did all the work here so I am crediting him with a Co-developed-by on all the other patches, so Arnd: please follow up on the other patches with a signed-off-by, unless you would rather me credit you in some other way. > Sorry for failing to submit these as a proper patch. If you send a new version, > I think you need to make sure you cover all of the above, using whichever > change you like best. I am still going to try to get Linus' suggestion working since it actually solves the problem, but I would rather get the above suggested fix out there since it is quick and I know it works. Cheers
Powered by blists - more mailing lists