netdev - Re: [PATCH net-next v4] net: openvswitch: IPv6: Add IPv6 extension header support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210916191449.668dea06@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 16 Sep 2021 19:14:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Toms Atteka <cpp.code.lv@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4] net: openvswitch: IPv6: Add IPv6 extension
 header support

On Thu, 16 Sep 2021 13:44:09 -0700 Toms Atteka wrote:
> +/**
> + * Parses packet and sets IPv6 extension header flags.
> + *
> + * skb          buffer where extension header data starts in packet
> + * nh           ipv6 header
> + * ext_hdrs     flags are stored here
> + *
> + * OFPIEH12_UNREP is set if more than one of a given IPv6 extension header
> + * is unexpectedly encountered. (Two destination options headers may be
> + * expected and would not cause this bit to be set.)
> + *
> + * OFPIEH12_UNSEQ is set if IPv6 extension headers were not in the order
> + * preferred (but not required) by RFC 2460:
> + *
> + * When more than one extension header is used in the same packet, it is
> + * recommended that those headers appear in the following order:
> + *      IPv6 header
> + *      Hop-by-Hop Options header
> + *      Destination Options header
> + *      Routing header
> + *      Fragment header
> + *      Authentication header
> + *      Encapsulating Security Payload header
> + *      Destination Options header
> + *      upper-layer header
> + */

This is not a valid kdoc format, please read
Documentation/doc-guide/kernel-doc.rst and double check for warnings
with scripts/kernel-doc -none.

> +static void get_ipv6_ext_hdrs(struct sk_buff *skb, struct ipv6hdr *nh,
> +			      u16 *ext_hdrs)
> +{