netdev - Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210920132801.7ab99be1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 20 Sep 2021 13:28:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
        netdev@...r.kernel.org, johannes@...solutions.net,
        ryazanov.s.a@...il.com, loic.poulain@...aro.org,
        krishna.c.sudi@...el.com, m.chetan.kumar@...el.com,
        linuxwwan@...el.com
Subject: Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd
 collection

On Mon, 20 Sep 2021 09:10:11 +0000 patchwork-bot+netdevbpf@...nel.org
wrote:
> On Sun, 19 Sep 2021 22:54:24 +0530 you wrote:
> > This patch series brings-in support for M.2 7560 Device firmware flashing &
> > coredump collection using devlink.
> > - Driver Registers with Devlink framework.
> > - Register devlink params callback for configuring device params
> >   required in flashing or coredump flow.
> > - Implements devlink ops flash_update callback that programs modem
> >   firmware.
> > - Creates region & snapshot required for device coredump log collection.
> > 
> > [...]  
> 
> Here is the summary with links:
>   - [V2,net-next,1/6] net: wwan: iosm: devlink registration
>     https://git.kernel.org/netdev/net-next/c/4dcd183fbd67
>   - [V2,net-next,2/6] net: wwan: iosm: fw flashing support
>     https://git.kernel.org/netdev/net-next/c/b55734745568
>   - [V2,net-next,3/6] net: wwan: iosm: coredump collection support
>     https://git.kernel.org/netdev/net-next/c/09e7b002ff67
>   - [V2,net-next,4/6] net: wwan: iosm: transport layer support for fw flashing/cd
>     https://git.kernel.org/netdev/net-next/c/8d9be0634181
>   - [V2,net-next,5/6] net: wwan: iosm: devlink fw flashing & cd collection documentation
>     https://git.kernel.org/netdev/net-next/c/64302024bce5
>   - [V2,net-next,6/6] net: wwan: iosm: fw flashing & cd collection infrastructure changes
>     https://git.kernel.org/netdev/net-next/c/607d574aba6e
> 
> You are awesome, thank you!

I had to post a revert of v1 because it was merged too quickly,
and the same exact thing happens to v2. Maybe it's just me but 
feels very disheartening.

The flashing API is really easy to extended all the devlink params 
here should be part of the flashing API.