netdev - Re: [RFC PATCH net-next 12/12] net: lan966x: add ethtool configuration and statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210920133126.642449aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 20 Sep 2021 13:31:26 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     <davem@...emloft.net>, <robh+dt@...nel.org>, <andrew@...n.ch>,
        <linux@...linux.org.uk>, <f.fainelli@...il.com>,
        <alexandre.belloni@...tlin.com>, <vladimir.oltean@....com>,
        <UNGLinuxDriver@...rochip.com>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <linux-pm@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 12/12] net: lan966x: add ethtool
 configuration and statistics

On Mon, 20 Sep 2021 11:52:18 +0200 Horatiu Vultur wrote:
> +static void lan966x_get_eth_mac_stats(struct net_device *dev,
> +				      struct ethtool_eth_mac_stats *mac_stats)

Great to see this API used, please also consider adding RMON stats
since the seem to be present.